Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: CLI to update registry credentials #45

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: CLI to update registry credentials #45

wants to merge 2 commits into from

Conversation

dkoshkin
Copy link
Contributor

@dkoshkin dkoshkin commented Dec 9, 2022

New simple CLI that can update registry credentials

➜  credential-manager update registry-credentials --address=docker.io --username=user --password=pass
Updated credentials
➜ kubectl view-secret -n kube-system   staticcredentialproviderauth
Choosing key: static-image-credentials.json
{"kind":"CredentialProviderResponse","apiVersion":"credentialprovider.kubelet.k8s.io/v1beta1","cacheKeyType":"Image","cacheDuration":"0s","auth":{"docker.io":{"username":"user","password":"pass"}}}

@dkoshkin dkoshkin force-pushed the dkoshkin/cli branch 5 times, most recently from e4bdd11 to 7143ecb Compare December 9, 2022 15:54
Base automatically changed from jimmi/daemonset to main December 12, 2022 15:25
@github-actions github-actions bot added feature and removed feature labels Dec 12, 2022
@jimmidyson
Copy link
Contributor

Love the idea! What do you think about set-credentials, get-credentials, delete-credentials instead of update?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimmidyson jimmidyson Awaiting requested review from jimmidyson

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dkoshkin @jimmidyson